Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: fix test where aborted should not be emitted #28120

Closed
wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jun 7, 2019

This fixes two http tests to properly catch a potential bug where aborted is incorrectly emitted.

I don't know how to fix the actual "bug".

Checklist
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 7, 2019
@ronag ronag mentioned this pull request Jun 7, 2019
4 tasks
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passes.

@ronag
Copy link
Member Author

ronag commented Jun 7, 2019

@cjihrig the point is that the test will NOT pass, this makes them fail (as they should?), but doesn't fix the underlying issue. I don't know how to fix it at the moment.

@ronag
Copy link
Member Author

ronag commented Jun 8, 2019

I think the tests failed because of a regression in http_parser_llhttp. I forced it to the legacy parser to make it pass (as it should).

@ronag
Copy link
Member Author

ronag commented Jun 8, 2019

I've included these test updates in #27984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants