Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: fix tab completion bug #2816

Closed
wants to merge 1 commit into from
Closed

readline: fix tab completion bug #2816

wants to merge 1 commit into from

Conversation

mtharrison
Copy link
Contributor

This fixes a problem where tab completion is empty when the input
stream column size is undefined. As a solution we can force maxColumns
to 1 in this scenario.

Fixes: #2396
Related PR: #2612

@mtharrison
readline: fix tab completion bug
57d2fe1 
This fixes a problem where tab completion is empty when the input
stream column size is undefined. As a solution we can force maxColumns
to 1 in this scenario.
@Fishrock123 Fishrock123 added the repl Issues and PRs related to the REPL subsystem. label Sep 11, 2015
@mscdex mscdex added readline Issues and PRs related to the built-in readline module. and removed repl Issues and PRs related to the REPL subsystem. labels Sep 11, 2015
@silverwind
Copy link
Contributor

LGTM now.

@Fishrock123
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/282/

silverwind pushed a commit that referenced this pull request Sep 18, 2015
@mtharrison @silverwind
readline: fix tab completion bug
e29e470 
This fixes a problem where tab completion is empty when the input
stream column size is undefined. As a solution we can force maxColumns
to 1 in this scenario.

PR-URL: #2816
Fixes: #2396
Reviewed-By: Roman Reiss <me@silverwind.io>
@silverwind
Copy link
Contributor

Landed in e29e470. Thanks @mtharrison!

@silverwind silverwind closed this Sep 18, 2015
@mtharrison
Copy link
Contributor Author

🎉 This makes me so happy! Thank you!

@mtharrison mtharrison deleted the readline-undefined-columns2 branch September 18, 2015 16:37
Fishrock123 pushed a commit that referenced this pull request Sep 20, 2015
@mtharrison @Fishrock123
readline: fix tab completion bug
d4cd5ac 
This fixes a problem where tab completion is empty when the input
stream column size is undefined. As a solution we can force maxColumns
to 1 in this scenario.

PR-URL: #2816
Fixes: #2396
Reviewed-By: Roman Reiss <me@silverwind.io>
@trevnorris trevnorris mentioned this pull request Sep 20, 2015
Closed
@rvagg rvagg mentioned this pull request Sep 22, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

readline: output of completions when column is undefined
4 participants
@mtharrison @silverwind @Fishrock123 @mscdex