Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: re-enable custom V8 snapshot by default #28181

Closed
wants to merge 2 commits into from
Closed

build: re-enable custom V8 snapshot by default #28181

wants to merge 2 commits into from

Commits on Jun 11, 2019

  1. tools: assert that the snapshot can be rehashed in node_mksnapshot

    @joyeecheung
    joyeecheung committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    7d917d3 View commit details
    Browse the repository at this point in the history

  2. build: turn on custom V8 snapshot by default 

    This patch re-enables custom V8 snapshot integration. Also renames
the experimental configure switch from `--with-node-snapshot`
to `--without-node-snapshot` to be consistent with`--without-snapshot`
which is used for the default V8 snapshot.
    @joyeecheung
    joyeecheung committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    c1a2c64 View commit details
    Browse the repository at this point in the history