Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: add cpu info to report output #28188

Closed
wants to merge 1 commit into from
Closed

report: add cpu info to report output #28188

wants to merge 1 commit into from

Commits on Jun 14, 2019

  1. report: add cpu info to report output 

    The report shows CPU consumption %, but without the number of CPU cores,
a consumer cannot tell if the percent (given across all cores) is
actually problematic. E.g., 100% on one CPU is a problem, but 100% on
four CPUs is not necessarily.

This change adds CPU information (similar to `os.cpus()`) to the report
output. Extra info besides the count is also provided as to avoid future
breaking changes in the eventuality that someone needs it; changing the
datatype of `header.cpus` would be breaking.

PR-URL: nodejs#28188
Refs: nodejs/diagnostics#307
    @boneskull
    boneskull committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    7c2fa6b View commit details
    Browse the repository at this point in the history