Skip to content

Conversation

@Trott
Copy link
Member

@Trott Trott commented Jun 16, 2019

Several minor improvements to text. Remove some repetition.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jun 16, 2019
@Trott
Copy link
Member Author

Trott commented Jun 16, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 17, 2019
Several minor improvements to text. Remove some repetition.

PR-URL: nodejs#28255
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott Trott force-pushed the assertion-error branch from 887207f to 17a5eba Compare June 18, 2019 23:19
@Trott
Copy link
Member Author

Trott commented Jun 18, 2019

Landed in 17a5eba

@Trott Trott merged commit 17a5eba into nodejs:master Jun 18, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
Several minor improvements to text. Remove some repetition.

PR-URL: #28255
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
@Trott Trott deleted the assertion-error branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants