Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add tunniclm as a collaborator #2826

Closed
wants to merge 1 commit into from

Conversation

tunniclm
Copy link
Contributor

Refer: #2413

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Sep 11, 2015
@rvagg
Copy link
Member

rvagg commented Sep 11, 2015

@Fishrock123, @chrisdickinson can one of you please schedule an onboarding asap? If neither of you have time do you have someone else that you'd like to nominate that you think could run them just as well?

@cjihrig
Copy link
Contributor

cjihrig commented Sep 12, 2015

Do you have to be TSC to run an onboarding?

@rvagg
Copy link
Member

rvagg commented Sep 12, 2015

I don't think so, but I'd like to hear @Fishrock123 || @chrisdickinson sign off on the individual doing it since they've been tuning the process

@Fishrock123
Copy link
Contributor

Fwiw I onboarded @tunniclm at NodeConf eu. He has yet to make a collaborator pr I think.

@rvagg
Copy link
Member

rvagg commented Sep 12, 2015

@Fishrock123 this is that PR, so you're welcome to lgtm it and add him as collaborator if you're signing off on this

@Fishrock123
Copy link
Contributor

Doh. LGTM

@Fishrock123
Copy link
Contributor

@tunniclm please land with this metadata when you are ready:

Refs: https://github.com/nodejs/node/issues/2413
PR-URL: https://github.com/nodejs/node/pull/2826
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Refs: nodejs#2413
PR-URL: nodejs#2826
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

@orangemocha can you get @tunniclm a CI account?

tunniclm added a commit that referenced this pull request Sep 14, 2015
Refs: #2413
PR-URL: #2826
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@tunniclm
Copy link
Contributor Author

Thanks :)

Landed in 5579e85

@tunniclm tunniclm closed this Sep 14, 2015
@orangemocha
Copy link
Contributor

@tunniclm : you already have a CI account :) I resent the original email just in case.

tunniclm added a commit that referenced this pull request Sep 15, 2015
Refs: #2413
PR-URL: #2826
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Sep 15, 2015
7 tasks
tunniclm added a commit that referenced this pull request Sep 15, 2015
Refs: #2413
PR-URL: #2826
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@rvagg rvagg mentioned this pull request Sep 15, 2015
@tunniclm
Copy link
Contributor Author

@orangemocha : Thanks!

@rvagg rvagg mentioned this pull request Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants