-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v10.x] n-api: implement date object #28298
Closed
gabrielschulhof
wants to merge
1
commit into
nodejs:v10.x-staging
from
gabrielschulhof:backport-25917-to-v10.x
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"targets": [ | ||
{ | ||
"target_name": "test_date", | ||
"sources": [ | ||
"test_date.c" | ||
] | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
'use strict'; | ||
|
||
const common = require('../../common'); | ||
|
||
// This tests the date-related n-api calls | ||
|
||
const assert = require('assert'); | ||
const test_date = require(`./build/${common.buildType}/test_date`); | ||
|
||
const dateTypeTestDate = test_date.createDate(1549183351); | ||
assert.strictEqual(test_date.isDate(dateTypeTestDate), true); | ||
|
||
assert.strictEqual(test_date.isDate(new Date(1549183351)), true); | ||
|
||
assert.strictEqual(test_date.isDate(2.4), false); | ||
assert.strictEqual(test_date.isDate('not a date'), false); | ||
assert.strictEqual(test_date.isDate(undefined), false); | ||
assert.strictEqual(test_date.isDate(null), false); | ||
assert.strictEqual(test_date.isDate({}), false); | ||
|
||
assert.strictEqual(test_date.getDateValue(new Date(1549183351)), 1549183351); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
#define NAPI_EXPERIMENTAL | ||
|
||
#include <node_api.h> | ||
#include "../common.h" | ||
|
||
static napi_value createDate(napi_env env, napi_callback_info info) { | ||
size_t argc = 1; | ||
napi_value args[1]; | ||
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL)); | ||
|
||
NAPI_ASSERT(env, argc >= 1, "Wrong number of arguments"); | ||
|
||
napi_valuetype valuetype0; | ||
NAPI_CALL(env, napi_typeof(env, args[0], &valuetype0)); | ||
|
||
NAPI_ASSERT(env, valuetype0 == napi_number, | ||
"Wrong type of arguments. Expects a number as first argument."); | ||
|
||
double time; | ||
NAPI_CALL(env, napi_get_value_double(env, args[0], &time)); | ||
|
||
napi_value date; | ||
NAPI_CALL(env, napi_create_date(env, time, &date)); | ||
|
||
return date; | ||
} | ||
|
||
static napi_value isDate(napi_env env, napi_callback_info info) { | ||
napi_value date, result; | ||
size_t argc = 1; | ||
bool is_date; | ||
|
||
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, &date, NULL, NULL)); | ||
NAPI_CALL(env, napi_is_date(env, date, &is_date)); | ||
NAPI_CALL(env, napi_get_boolean(env, is_date, &result)); | ||
|
||
return result; | ||
} | ||
|
||
static napi_value getDateValue(napi_env env, napi_callback_info info) { | ||
napi_value date, result; | ||
size_t argc = 1; | ||
double value; | ||
|
||
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, &date, NULL, NULL)); | ||
NAPI_CALL(env, napi_get_date_value(env, date, &value)); | ||
NAPI_CALL(env, napi_create_double(env, value, &result)); | ||
|
||
return result; | ||
} | ||
|
||
EXTERN_C_START | ||
napi_value Init(napi_env env, napi_value exports) { | ||
napi_property_descriptor descriptors[] = { | ||
DECLARE_NAPI_PROPERTY("createDate", createDate), | ||
DECLARE_NAPI_PROPERTY("isDate", isDate), | ||
DECLARE_NAPI_PROPERTY("getDateValue", getDateValue), | ||
}; | ||
|
||
NAPI_CALL(env, napi_define_properties( | ||
env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors)); | ||
|
||
return exports; | ||
} | ||
EXTERN_C_END | ||
|
||
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
napiVersion
shouldn't be set for experimental API's? #28330There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardlau OK, that'll have to be backported as well, then.