Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: split routines used to enhance fatal exception stack traces #28308

Closed
wants to merge 1 commit into from

Commits on Jun 19, 2019

  1. process: split routines used to enhance fatal exception stack traces

    Previously the enhancement were done right after emitting
    `'uncaughtException'`, which meant by the time we knew the
    exception was fatal in C++, the error.stack had already been
    patched.
    
    This patch moves those routines to be called later during the
    fatal exception handling, and split them into two stages:
    before and after the inspector is notified by the invocation of
    `V8Inspector::exceptionThrown`. We now expand the stack to include
    additional informations about unhandled 'error' events before
    the inspector is notified, but delay the highlighting of the
    frames until after the inspector is notified, so that the
    ANSI escape sequences won't show up in the inspector console.
    joyeecheung committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    60e3f81 View commit details
    Browse the repository at this point in the history