doc: fix nits regarding stream utilities #28385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
* Unify headings. * Conform method mentions with the style guide. * Fix links.
Trott
approved these changes
Jun 22, 2019
cjihrig
approved these changes
Jun 22, 2019
ZYSzys
approved these changes
Jun 22, 2019
BridgeAR
approved these changes
Jun 22, 2019
lpinca
approved these changes
Jun 22, 2019
trivikr
approved these changes
Jun 23, 2019
jasnell
approved these changes
Jun 23, 2019
Trott
added
the
author ready
|
Landed in daa512b |
addaleax
pushed a commit
that referenced
this pull request
Jun 25, 2019
* Unify headings. * Conform method mentions with the style guide. * Fix links. PR-URL: #28385 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
* Unify headings. * Conform method mentions with the style guide. * Fix links. PR-URL: #28385 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes### Readable.from()->### stream.Readable.from()heading change seems suboptimal and non-typical, but it seems it would be wrong to place this part with descriptions ofReadableinstances or to leave it as is along with otherstream.*utilities, in incorrect structure and sorting place.