Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] n-api: make func argument of napi_create_threadsafe_function optional #28399

Closed
wants to merge 1 commit into from
Closed

[v10.x] n-api: make func argument of napi_create_threadsafe_function optional #28399

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

PR-URL: #27791
Refs: #27592
Reviewed-By: Gabriel Schulhof gabriel.schulhof@intel.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. v10.x labels Jun 24, 2019
mhdawson
mhdawson approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

richardlau
richardlau reviewed Jun 24, 2019
View reviewed changes
doc/api/n-api.md Outdated Show resolved Hide resolved
mhdawson
mhdawson reviewed Jun 26, 2019
View reviewed changes
doc/api/n-api.md Outdated Show resolved Hide resolved
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 4, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24267/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24311/

@gabrielschulhof gabrielschulhof mentioned this pull request Jul 8, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24412/

@gabrielschulhof
Copy link
Contributor Author

Rebased.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24415/

@mhdawson
Copy link
Member

@BethGriggs @gabrielschulhof another one that should possibly be in the 10.16.1

@mhdawson
Copy link
Member

Or tagged with Semver minor if that is the reason it won't be included.

@BethGriggs BethGriggs added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 17, 2019
@Trott
Copy link
Member

Trott commented Jul 30, 2019

Removing author ready because IIUC only @nodejs/backporters are supposed to land to 10.x-staging. Feel free to re-add if they are using author ready, but judging by the fact that this hasn't landed after 25 days with author ready applied, I'm guessing they're not. (Which is totally OK!)

@Trott Trott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 30, 2019
@gabrielschulhof
Copy link
Contributor Author

Rebased.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25542/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25545/

@legendecas
n-api: make func argument of napi_create_threadsafe_function optional
116f8ec 
PR-URL: nodejs#27791
Refs: nodejs#27592
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
@gabrielschulhof
Copy link
Contributor Author

Rebased.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25582/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25584/

BethGriggs pushed a commit that referenced this pull request Sep 20, 2019
@legendecas @BethGriggs
n-api: make func argument of napi_create_threadsafe_function optional
f862276 
PR-URL: #27791
Backport-PR-URL: #28399
Refs: #27592
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
@BethGriggs
Copy link
Member

Landed on v10.x-staging

@BethGriggs BethGriggs closed this Sep 20, 2019
@gabrielschulhof gabrielschulhof deleted the backport-27791-to-v10.x branch March 13, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau left review comments

@legendecas legendecas legendecas approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gabrielschulhof @nodejs-github-bot @mhdawson @Trott @BethGriggs @richardlau @legendecas @BridgeAR