Skip to content

[v8.x] n-api: make func argument of napi_create_threadsafe_function optional #28400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gabrielschulhof wants to merge 1 commit into from
Closed

[v8.x] n-api: make func argument of napi_create_threadsafe_function optional #28400

gabrielschulhof wants to merge 1 commit into from
+69 −11

Conversation

@gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Jun 24, 2019

PR-URL: #27791
Refs: #27592
Reviewed-By: Gabriel Schulhof gabriel.schulhof@intel.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. v8.x labels Jun 24, 2019
@gabrielschulhof gabrielschulhof changed the title n-api: make func argument of napi_create_threadsafe_function optional [v8.x] n-api: make func argument of napi_create_threadsafe_function optional Jun 24, 2019
legendecas
legendecas approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson reviewed Jun 24, 2019
View reviewed changes
@gabrielschulhof gabrielschulhof force-pushed the backport-27791-to-v8.x branch from 5d69cd4 to 5b1f497 Compare June 25, 2019 19:26
mhdawson
mhdawson reviewed Jun 26, 2019
View reviewed changes
@gabrielschulhof gabrielschulhof force-pushed the backport-27791-to-v8.x branch from 5b1f497 to 64849c3 Compare July 1, 2019 18:05
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 4, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 4, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24268/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 6, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24312/

@gabrielschulhof gabrielschulhof mentioned this pull request Jul 8, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 18, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24550/

mhdawson
mhdawson approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Jul 30, 2019

Removing author ready because IIUC only @nodejs/backporters are supposed to land to 8.x-staging. Feel free to re-add if they are using author ready, but judging by the fact that this hasn't landed after 25 days with author ready applied, I'm guessing they're not. (Which is totally OK!)

@Trott Trott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 30, 2019
@legendecas
n-api: make func argument of napi_create_threadsafe_function optional
d0a05d0 
PR-URL: nodejs#27791
Refs: nodejs#27592
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Sep 2, 2019

Rebased.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25576/

@BethGriggs BethGriggs added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 19, 2019
@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Oct 13, 2019

v8.x will receive no further minor versions.

@gabrielschulhof gabrielschulhof deleted the backport-27791-to-v8.x branch October 13, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

@legendecas legendecas legendecas approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gabrielschulhof @nodejs-github-bot @Trott @richardlau @legendecas @mhdawson @BethGriggs @BridgeAR