Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove disabled test #2841

Closed
wants to merge 1 commit into from
Closed

test: remove disabled test #2841

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 12, 2015

Remove test file that has been in disabled from its very first commit
(9ccf0e5) in 2011. It is a test for
nodejs/node-v0.x-archive#670 from 2011. There
are no assertions in the test. In that regard, it is more debugging code
than a test.

Remove test file that has been in disabled from its very first commit
(9ccf0e5) in 2011. It is a test for
nodejs/node-v0.x-archive#670 from 2011. There
are no assertions in the test. In that regard, it is more debugging code
than a test.
@brendanashworth brendanashworth added the test Issues and PRs related to the tests. label Sep 12, 2015
@mscdex
Copy link
Contributor

mscdex commented Sep 12, 2015

LGTM

1 similar comment
@yosuke-furukawa
Copy link
Member

LGTM

Trott added a commit that referenced this pull request Sep 14, 2015
Remove test file that has been in disabled from its very first commit
(9ccf0e5) in 2011. It is a test for
nodejs/node-v0.x-archive#670 from 2011. There
are no assertions in the test. In that regard, it is more debugging code
than a test.

PR-URL: #2841
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
@Trott
Copy link
Member Author

Trott commented Sep 14, 2015

Landed in 999d25b

@Trott Trott closed this Sep 14, 2015
Trott added a commit that referenced this pull request Sep 15, 2015
Remove test file that has been in disabled from its very first commit
(9ccf0e5) in 2011. It is a test for
nodejs/node-v0.x-archive#670 from 2011. There
are no assertions in the test. In that regard, it is more debugging code
than a test.

PR-URL: #2841
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Sep 15, 2015
7 tasks
Trott added a commit that referenced this pull request Sep 15, 2015
Remove test file that has been in disabled from its very first commit
(9ccf0e5) in 2011. It is a test for
nodejs/node-v0.x-archive#670 from 2011. There
are no assertions in the test. In that regard, it is more debugging code
than a test.

PR-URL: #2841
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
@rvagg rvagg mentioned this pull request Sep 15, 2015
@rvagg rvagg mentioned this pull request Sep 22, 2015
@Trott Trott deleted the stale-tests branch January 9, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants