Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-vm-timeout-escape-nexttick #28461

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-vm-timeout-escape-nexttick #28461

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 27, 2019

Fixes: #24120

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jun 27, 2019
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 27, 2019
@Trott
Copy link
Member Author

Trott commented Jun 28, 2019

node-stress-single-test isn't configured right now, so a stress test may have to wait unless I think of some other way to cajole a stress test out of CI....

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott
Copy link
Member Author

Trott commented Jun 28, 2019

(Since this is a known_issues test, the flakiness problem is that it doesn't always fail. By looping, we make sure it fails. At least, that's the hope.)

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24135/

@danbev
Copy link
Contributor

danbev commented Jul 2, 2019

Landed in e008ca8.

@danbev danbev closed this Jul 2, 2019
pull bot pushed a commit to zys-contrib/node that referenced this pull request Jul 2, 2019
@Trott @danbev
test: fix flaky test-vm-timeout-escape-nexttick
e008ca8 
PR-URL: nodejs#28461
Fixes: nodejs#24120
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@Trott @targos
test: fix flaky test-vm-timeout-escape-nexttick
7665bad 
PR-URL: #28461
Fixes: #24120
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@Trott @targos
test: fix flaky test-vm-timeout-escape-nexttick
8a64b70 
PR-URL: #28461
Fixes: #24120
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
@Trott Trott deleted the fix-flaky-escape-test branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate flaky known_issues/test-vm-timeout-escape-nexttick
5 participants
@Trott @nodejs-github-bot @danbev @jasnell @lpinca