Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: modify getReport() to return an Object #28630

Closed
wants to merge 1 commit into from
Closed

report: modify getReport() to return an Object #28630

wants to merge 1 commit into from

Commits on Jul 12, 2019

  1. report: modify getReport() to return an Object 

    It's likely that anyone using `process.report.getReport()` will be
processing the return value thereafter (e.g., filtering fields or
redacting secrets). This change eliminates boilerplate by calling
`JSON.parse()` on the return value.

Also modified the `validateContent()` and `validate()` test helpers in
`test/common/report.js` to be somewhat more obvious and helpful. Of
note, a report failing validation will now be easier (though still not
_easy_) to read when prepended to the stack trace.

- Refs: nodejs/diagnostics#315
    @boneskull
    boneskull committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    a432b07 View commit details
    Browse the repository at this point in the history