Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: refactor emit error #28696

Closed
wants to merge 1 commit into from
Closed

http: refactor emit error #28696

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 15, 2019

A small cleanup.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Jul 15, 2019
lpinca
lpinca reviewed Jul 15, 2019
View reviewed changes
lib/_http_client.js Outdated Show resolved Hide resolved
@ronag ronag mentioned this pull request Jul 15, 2019
Closed
4 tasks
@ronag
Copy link
Member Author

ronag commented Jul 15, 2019

Blocked by #20077

@trivikr
Copy link
Member

trivikr commented Jul 15, 2019

Code in PR #20077 landed, this PR can be rebased

@ronag
Copy link
Member Author

ronag commented Jul 15, 2019

@trivikr rebased

@trivikr
Copy link
Member

trivikr commented Jul 15, 2019

I missed comment from @Trott
#20077 was reverted #20077 (comment)

@Trott
Copy link
Member

Trott commented Jul 17, 2019

Is this blocked on something still? #28683 perhaps?

@ronag
Copy link
Member Author

ronag commented Jul 17, 2019

@Trott I don't think this is relevant anymore due to #28683.

@ronag ronag closed this Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ronag @trivikr @Trott @jasnell @addaleax @lpinca @nodejs-github-bot