Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add public virtual destructor for KVStore #28737

Closed
wants to merge 1 commit into from
Closed

src: add public virtual destructor for KVStore #28737

wants to merge 1 commit into from
+7 −0

Commits on Jul 20, 2019

  1. src: add public virtual destructor for KVStore 

    As KVStore has derived classes, it is essential to
declare a public virtual destructor in the base
KVStore class. Otherwise, deleting derived class
instances using base class pointers would
potentially cause undefined behaviour.

Additionally, since we are implementing a non-default
destructor, the special member functions have also
been implemented in order to abide by the rule of five.
    @GauthamBanasandra
    GauthamBanasandra committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    e2fb368 View commit details
    Browse the repository at this point in the history