Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: jenkins-iojs.nodesource.com -> ci.nodejs.org, iojs.org/download -> nodejs.org/download #2886

Closed
wants to merge 1 commit into from

Conversation

mgol
Copy link
Contributor

@mgol mgol commented Sep 15, 2015

The Jenkins URL has changed from https://jenkins-iojs.nodesource.com
to https://ci.nodejs.org. The former address now redirects to the
latter.

The new download location is https://nodejs.org/download/release/;
the configure script was still referring to
https://iojs.org/download/release/.

(there are separate commits for these changes)

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Sep 15, 2015
@rvagg
Copy link
Member

rvagg commented Sep 16, 2015

lgtm

@evanlucas
Copy link
Contributor

LGTM

@@ -11,11 +11,11 @@ Release authorization is given by the node.js TSC. Once authorized, an individua

There are three relevant Jenkins jobs that should be used for a release flow:

**a.** **Test runs:** **[iojs+any-pr+multi](https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/)** is used for a final full-test run to ensure that the current *HEAD* is stable.
**a.** **Test runs:** **[iojs+any-pr+multi](https://ci.nodejs.org/job/iojs+any-pr+multi/)** is used for a final full-test run to ensure that the current *HEAD* is stable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we use this job anymore. Probably you can fix this as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be https://ci.nodejs.org/job/node-test-pull-request/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed & rebased over master, here and in one other place below.

I assume iojs+release is still used?

@thefourtheye
Copy link
Contributor

@rvagg Are all the jobs right? We can fix it now itself

@mgol
Copy link
Contributor Author

mgol commented Sep 16, 2015

The only job in doc/releases.md that have iojs in its name is currently iojs+release; if that was changed to a node-based one, there wouldn't be any more left.

@silverwind
Copy link
Contributor

iojs+release is still the main release job. Can we rename it?

@silverwind
Copy link
Contributor

@mzgol terrible sorry, but it appears I landed one of the changes here in 76c80d4, which breaks this patch. Could you remove the second commit? Also, LGTM.

The Jenkins URL has changed from https://jenkins-iojs.nodesource.com
to https://ci.nodejs.org. The former address now redirects to the
latter. Some jobs has also changed names.
@mgol
Copy link
Contributor Author

mgol commented Sep 23, 2015 via email

silverwind pushed a commit that referenced this pull request Sep 23, 2015
The Jenkins URL has changed from https://jenkins-iojs.nodesource.com
to https://ci.nodejs.org. The former address now redirects to the
latter. Some jobs has also changed names.

PR-URL: #2886
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@silverwind
Copy link
Contributor

Thanks, landed in 02448c6.

@silverwind silverwind closed this Sep 23, 2015
@mgol mgol deleted the io2node branch September 24, 2015 14:49
Fishrock123 pushed a commit that referenced this pull request Sep 25, 2015
The Jenkins URL has changed from https://jenkins-iojs.nodesource.com
to https://ci.nodejs.org. The former address now redirects to the
latter. Some jobs has also changed names.

PR-URL: #2886
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants