doc: revoke DEP0089 #28892
Merged
doc: revoke DEP0089 #28892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
deprecations
lpinca
approved these changes
Jul 29, 2019
Trott
approved these changes
Jul 30, 2019
|
/ping @BridgeAR @nodejs/assert |
antsmartian
approved these changes
Jul 30, 2019
benjamingr
approved these changes
Jul 31, 2019
Using the legacy assert module is not discouraged. Revoke DEP0089 to avoid user confusion. PR-URL: nodejs#28892 Fixes: nodejs#28780 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
3 tasks
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 2, 2019
The deprecation was revoked in nodejs#28892. PR-URL: nodejs#28909 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
Using the legacy assert module is not discouraged. Revoke DEP0089 to avoid user confusion. PR-URL: #28892 Fixes: #28780 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
BridgeAR
added
the
notable-change
|
Belated 👍 I have never been really happy with this. |
BridgeAR
added a commit
that referenced
this pull request
Aug 6, 2019
Notable changes:
* assert:
* Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig)
#28892
* crypto:
* The `outputLength` option is added to `crypto.createHash`
(Tobias Nießen) #28805
* The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
#28799
* n-api:
* Added APIs for per-instance state management (Gabriel Schulhof)
#28682
* report:
* Network interfaces get included in the report (cjihrig)
#28911
* src:
* `v8.getHeapCodeStatistics()` is now exported
(Yuriy Vasiyarov) #27978
PR-URL: #29017
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Aug 6, 2019
Notable changes:
* assert:
* Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig)
nodejs#28892
* crypto:
* The `outputLength` option is added to `crypto.createHash`
(Tobias Nießen) nodejs#28805
* The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
nodejs#28799
* n-api:
* Added APIs for per-instance state management (Gabriel Schulhof)
nodejs#28682
* report:
* Network interfaces get included in the report (cjihrig)
nodejs#28911
* src:
* `v8.getHeapCodeStatistics()` is now exported
(Yuriy Vasiyarov) nodejs#27978
PR-URL: nodejs#29017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the legacy assert module is not discouraged. Revoke DEP0089 to avoid user confusion.
Fixes: #28780
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes