doc: inconsistent indentation for list items #29330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Items at same level should have consistent indentation level. Addresses Markdownlint MD005 errors.
nschonni
commented
Aug 27, 2019
| @@ -1283,8 +1283,8 @@ Semver Patch: | |||
| Semver Minor: | |||
|
|
|||
| * **buffer**: | |||
| * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) [#7562](https://github.com/nodejs/node/pull/7562) | |||
| * backport --zero-fill-buffers cli option (James M Snell) [#5745](https://github.com/nodejs/node/pull/5745) | |||
| * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) [#7562](https://github.com/nodejs/node/pull/7562) | |||
There was a problem hiding this comment.
This does change the rendering, but it wasn't indented below the "buffer" section before
Trott
approved these changes
Aug 27, 2019
trivikr
approved these changes
Aug 27, 2019
trivikr
added
the
author ready
lpinca
approved these changes
Aug 27, 2019
jasnell
approved these changes
Aug 28, 2019
|
Landed in 1d5186e |
Trott
pushed a commit
that referenced
this pull request
Aug 29, 2019
Items at same level should have consistent indentation level. Addresses Markdownlint MD005 errors. PR-URL: #29330 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
Items at same level should have consistent indentation level. Addresses Markdownlint MD005 errors. PR-URL: #29330 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
Items at same level should have consistent indentation level. Addresses Markdownlint MD005 errors. PR-URL: #29330 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes