Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-http-server-keepalive-req-gc #29347

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-http-server-keepalive-req-gc #29347

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 27, 2019

Use server to keep the event loop open until the ongc listener runs.

Fixes: #29344

Collaborators, please 👍 to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@Trott Trott added test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 27, 2019
@Trott Trott mentioned this pull request Aug 27, 2019
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25275/

@Trott Trott changed the title test: fix falky test-http-server-keepalive-req-gc test: fix flaky test-http-server-keepalive-req-gc Aug 27, 2019
@Trott
Copy link
Member Author

Trott commented Aug 27, 2019

CI is green. Some approvals for fast-tracking would be great.... @nodejs/testing

@Trott
test: fix flaky test-http-server-keepalive-req-gc
512d01a 
Use `server` to keep the event loop open until the `ongc` listener runs.

Fixes: nodejs#29344
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25278/

@addaleax
Copy link
Member

Actually, can you maybe also try to remove the skip-on-Windows part? That might be resolved now too

@Trott
Copy link
Member Author

Trott commented Aug 27, 2019

Actually, can you maybe also try to remove the skip-on-Windows part? That might be resolved now too

I was going to do that in a follow-up PR, just in case it's not resolved. Is that OK with you?

@addaleax
Copy link
Member

Sure!

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 28, 2019
@Trott
Copy link
Member Author

Trott commented Aug 28, 2019

Collaborators, please 👍 to fast-track.

danbev pushed a commit that referenced this pull request Aug 28, 2019
@Trott @danbev
test: fix flaky test-http-server-keepalive-req-gc
3ae6f5e 
Use `server` to keep the event loop open until the `ongc` listener runs.

PR-URL: #29347
Fixes: #29344
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@danbev
Copy link
Contributor

danbev commented Aug 28, 2019

Landed in 3ae6f5e.

@danbev danbev closed this Aug 28, 2019
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@Trott @BridgeAR
test: fix flaky test-http-server-keepalive-req-gc
e3cfbba 
Use `server` to keep the event loop open until the `ongc` listener runs.

PR-URL: #29347
Fixes: #29344
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@Trott @BridgeAR
test: fix flaky test-http-server-keepalive-req-gc
bd1e8ea 
Use `server` to keep the event loop open until the `ongc` listener runs.

PR-URL: #29347
Fixes: #29344
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@Trott Trott deleted the fix-req-gc-test branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky test-http-server-keepalive-req-gc.js
4 participants
@Trott @nodejs-github-bot @addaleax @danbev