doc: remove multiple consecutive blank lines #29352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
Aug 28, 2019
nschonni
commented
Aug 28, 2019
nschonni
force-pushed
the
doc--remove-multiple-consecutive-blank-lines
branch
from
95a14a2
to
4da634e
Compare
jasnell
approved these changes
Aug 28, 2019
These are rendered as single breaks. Addresses Markdownlint MD012 rule.
nschonni
force-pushed
the
doc--remove-multiple-consecutive-blank-lines
branch
from
4da634e
to
954d153
Compare
|
Rebased to fix merge conflict |
trivikr
approved these changes
Aug 30, 2019
trivikr
added
the
author ready
|
Landed in 9a46cfc |
Trott
pushed a commit
that referenced
this pull request
Aug 31, 2019
These are rendered as single breaks. Addresses Markdownlint MD012 rule. PR-URL: #29352 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
These are rendered as single breaks. Addresses Markdownlint MD012 rule. PR-URL: #29352 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
These are rendered as single breaks. Addresses Markdownlint MD012 rule. PR-URL: #29352 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Does remark-lint have this rule enabled @nschonni? |
|
No, it doesn't look like it right now https://github.com/nodejs/remark-preset-lint-node/blob/master/index.js |
|
Wouldn't it make sense to enforce this since this patch was merged?
…On Wed, Sep 4, 2019, 19:48 Nick Schonning ***@***.***> wrote:
No, it doesn't look like it right now
https://github.com/nodejs/remark-preset-lint-node/blob/master/index.js
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#29352?email_source=notifications&email_token=AACVLNPOZ72DSEONBJYLVL3QH7RHTA5CNFSM4IQ2L3KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD54HCDA#issuecomment-527986956>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACVLNJBZ54REIJP55YBUGLQH7RHTANCNFSM4IQ2L3KA>
.
|
|
Good idea, I've submitted a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes