tools: update ESLint to 6.3.0 #29382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ESLint to 6.3.0
ZYSzys
added
the
author ready
danbev
pushed a commit
that referenced
this pull request
Sep 3, 2019
Update ESLint to 6.3.0 PR-URL: #29382 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
|
Landed in d62d2b4. |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
Update ESLint to 6.3.0 PR-URL: #29382 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
Update ESLint to 6.3.0 PR-URL: #29382 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ESLint to 6.3.0
I'm also going to look into adding the new
reportUnusedDisableDirectivesto our configuration. We currently rely on passing the--report-unused-disable-directivesCLI flag to ESLint in two places. I'm hoping that moving that to the config file could cut the number in half.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes