Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: mk_snapshot fix blob wrong freeing operator #29384

Closed
wants to merge 1 commit into from
Closed

tools: mk_snapshot fix blob wrong freeing operator #29384

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 31, 2019
@devnexen devnexen changed the title src: mk_snapshot fix blob wrong freeing operator tools: mk_snapshot fix blob wrong freeing operator Aug 31, 2019
bnoordhuis
bnoordhuis approved these changes Aug 31, 2019
View reviewed changes
tools/snapshot/snapshot_builder.cc Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25322/

@Trott
Copy link
Member

Trott commented Sep 2, 2019

Landed in 94c944d

@Trott Trott closed this Sep 2, 2019
Trott pushed a commit that referenced this pull request Sep 2, 2019
@devnexen @Trott
tools: fix mksnapshot blob wrong freeing operator
94c944d 
PR-URL: #29384
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@devnexen @BridgeAR
tools: fix mksnapshot blob wrong freeing operator
78aa937 
PR-URL: #29384
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@devnexen @BridgeAR
tools: fix mksnapshot blob wrong freeing operator
3f68be1 
PR-URL: #29384
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@devnexen @nodejs-github-bot @Trott @bnoordhuis @addaleax @cjihrig @joyeecheung @richardlau