Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: exitedAfterDisconnect value can be false #29404

Closed
wants to merge 3 commits into from
Closed

doc: exitedAfterDisconnect value can be false #29404

wants to merge 3 commits into from

Conversation

nimit95
Copy link
Contributor

@nimit95 nimit95 commented Sep 2, 2019

Fixed the documentation to reflect the changes in the default value
of worker.exitedAfterDisconnect

Fixes: #28837
Refs: #3743

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nimit95
doc: exitedAfterDisconnect value can be false
4ae3d75 
Fixed the documentation to reflect the changes in the default value
of worker.exitedAfterDisconnect

Fixes: nodejs#28837
Refs: nodejs#3743
@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Sep 2, 2019
Trott
Trott reviewed Sep 3, 2019
View reviewed changes
doc/api/cluster.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Sep 3, 2019

Welcome @nimit95 and thanks for the pull request! I left a comment and hope it isn't too much trouble to add the requested details.

@nimit95
Copy link
Contributor Author

nimit95 commented Sep 4, 2019

@Trott thanks for the review, added the requested changes

Trott
Trott reviewed Sep 4, 2019
View reviewed changes
doc/api/cluster.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Sep 4, 2019

@nodejs/cluster

@nimit95 @Trott
Update doc/api/cluster.md
2ba17db 
Co-Authored-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 6, 2019

@nodejs/documentation

@Trott
Copy link
Member

Trott commented Sep 6, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3886/

@trivikr trivikr requested a review from sam-github September 6, 2019 03:24
@danbev danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 6, 2019
@Trott
Copy link
Member

Trott commented Sep 8, 2019

Doesn't strictly need it, but could use another review. @nodejs/collaborators

danbev pushed a commit that referenced this pull request Sep 9, 2019
@nimit95 @danbev
doc: exitedAfterDisconnect value can be false
695e819 
Fixed the documentation to reflect the changes in the default value
of worker.exitedAfterDisconnect

PR-URL: #29404
Fixes: #28837
Refs: #3743
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@danbev
Copy link
Contributor

danbev commented Sep 9, 2019

Landed in 695e819. 🎉

@danbev danbev closed this Sep 9, 2019
@nimit95 nimit95 deleted the patch-1 branch September 14, 2019 07:17
targos pushed a commit that referenced this pull request Sep 20, 2019
@nimit95 @targos
doc: exitedAfterDisconnect value can be false
5d4655c 
Fixed the documentation to reflect the changes in the default value
of worker.exitedAfterDisconnect

PR-URL: #29404
Fixes: #28837
Refs: #3743
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@nimit95 @BridgeAR
doc: exitedAfterDisconnect value can be false
9e63f91 
Fixed the documentation to reflect the changes in the default value
of worker.exitedAfterDisconnect

PR-URL: #29404
Fixes: #28837
Refs: #3743
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@devnexen devnexen devnexen approved these changes

@antsmartian antsmartian antsmartian approved these changes

@sam-github sam-github Awaiting requested review from sam-github

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

worker.exitedAfterDisconnect is false, after the worker process has exited using process.exit()
6 participants
@nimit95 @Trott @danbev @antsmartian @devnexen @nodejs-github-bot