Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove experimental Python 3 tests #29413

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 3, 2019

These tests do not help us to get closer to Python 3 compatibility and they take up valuable time yet they always fail.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

These tests do not help us to get closer to Python 3 compatibility and they take up valuable time yet they always fail.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Sep 3, 2019
@danbev danbev added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 3, 2019
@danbev
Copy link
Contributor

danbev commented Sep 3, 2019

Could we fast track this? Please give a 👍 if you agree or please remove the fast-track label if you disagree.

danbev pushed a commit that referenced this pull request Sep 3, 2019
These tests do not help us to get closer to Python 3 compatibility and
they take up valuable time yet they always fail.

PR-URL: #29413
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@danbev
Copy link
Contributor

danbev commented Sep 3, 2019

Landed in eb2deee.

@danbev danbev closed this Sep 3, 2019
@cclauss cclauss deleted the Remove-Python-3-tests branch September 3, 2019 12:28
@cclauss cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Sep 3, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
These tests do not help us to get closer to Python 3 compatibility and
they take up valuable time yet they always fail.

PR-URL: #29413
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants