v12.10.0 proposal

.github/PULL_REQUEST_TEMPLATE.md

@@ -14,3 +14,31 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
 - [ ] tests and/or benchmarks are included
 - [ ] documentation is changed or added
 - [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)
+
+<!--
+Developer's Certificate of Origin 1.1
+
+By making a contribution to this project, I certify that:
+
+(a) The contribution was created in whole or in part by me and I
+ have the right to submit it under the open source license
+ indicated in the file; or
+
+(b) The contribution is based upon previous work that, to the best
+ of my knowledge, is covered under an appropriate open source
+ license and I have the right under that license to submit that
+ work with modifications, whether created in whole or in part
+ by me, under the same open source license (unless I am
+ permitted to submit under a different license), as indicated
+ in the file; or
+
+(c) The contribution was provided directly to me by some other
+ person who certified (a), (b) or (c) and I have not modified
+ it.
+
+(d) I understand and agree that this project and the contribution
+ are public and that a record of the contribution (including all
+ personal information I submit with it, including my sign-off) is
+ maintained indefinitely and may be redistributed consistent with
+ this project or the open source license(s) involved.
+-->

.travis.yml

@@ -87,3 +87,31 @@ jobs:
  - if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
  bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST};
  fi
+
+ - name: "Python 3 is EXPERIMENTAL (Py36)"
+ language: node_js
+ node_js: "node"
+ install:
+ - pyenv global 3.6.7
+ - python3.6 -m pip install --upgrade pip
+ - make lint-py-build
+ script:
+ - NODE=$(which node) make lint lint-py
+ - python3.6 ./configure.py
+ - NODE=$(which node) make test
+
+ - name: "Python 3 is EXPERIMENTAL (Py37)"
+ language: node_js
+ node_js: "node"
+ install:
+ - pyenv global 3.7.1
+ - python3.7 -m pip install --upgrade pip
+ - make lint-py-build
+ script:
+ - NODE=$(which node) make lint lint-py
+ - python3.7 ./configure.py
+ - NODE=$(which node) make test
+
+ allow_failures:
+ - name: "Python 3 is EXPERIMENTAL (Py36)"
+ - name: "Python 3 is EXPERIMENTAL (Py37)"

BUILDING.md

@@ -665,16 +665,19 @@ during configuration if the ICU version is too old.
 #### Unix/macOS
 
 From an already-unpacked ICU:
+
 ```console
 $ ./configure --with-intl=[small-icu,full-icu] --with-icu-source=/path/to/icu
 ```
 
 From a local ICU tarball:
+
 ```console
 $ ./configure --with-intl=[small-icu,full-icu] --with-icu-source=/path/to/icu.tgz
 ```
 
 From a tarball URL:
+
 ```console
 $ ./configure --with-intl=full-icu --with-icu-source=http://url/to/icu.tgz
 ```

CHANGELOG.md

@@ -28,7 +28,8 @@ release.
 </tr>
 <tr>
  <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V12.md#12.9.1">12.9.1</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V12.md#12.10.0">12.10.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V12.md#12.9.1">12.9.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.9.0">12.9.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.8.1">12.8.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.8.0">12.8.0</a><br/>
@@ -105,7 +106,7 @@ release.
 </tr>
 </table>
 
-### Notes
+## Notes
 
 * The [Node.js Long Term Support plan](https://github.com/nodejs/Release) covers
  LTS releases.

COLLABORATOR_GUIDE.md

@@ -587,7 +587,7 @@ $ git push upstream master
 
 Close the pull request with a "Landed in `<commit hash>`" comment. If
 your pull request shows the purple merged status then you should still
-add the "Landed in <commit hash>..<commit hash>" comment if you added
+add the "Landed in \<commit hash>..\<commit hash>" comment if you added
 more than one commit.
 
 ### Troubleshooting

CPP_STYLE_GUIDE.md

@@ -29,7 +29,6 @@
  * [Avoid throwing JavaScript errors in C++ methods](#avoid-throwing-javascript-errors-in-c)
  * [Avoid throwing JavaScript errors in nested C++ methods](#avoid-throwing-javascript-errors-in-nested-c-methods)
 
-
 ## Guides and References
 
 The Node.js C++ codebase strives to be consistent in its use of language
@@ -186,6 +185,7 @@ class FancyContainer {
  ...
 }
 ```
+
 ## Memory Management
 
 ### Memory allocation
@@ -385,7 +385,6 @@ side effects.
 Node.js is built [without C++ exception handling][], so code using `throw` or
 even `try` and `catch` **will** break.
 
-
 [C++ Core Guidelines]: http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines
 [Google C++ Style Guide]: https://google.github.io/styleguide/cppguide.html
 [Google’s `cpplint`]: https://github.com/google/styleguide

LICENSE

@@ -1507,3 +1507,22 @@ The externally maintained libraries used by Node.js are:
  ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
  OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  """
+
+- rimraf, located at lib/internal/fs/rimraf.js, is licensed as follows:
+ """
+ The ISC License
+
+ Copyright (c) Isaac Z. Schlueter and Contributors
+
+ Permission to use, copy, modify, and/or distribute this software for any
+ purpose with or without fee is hereby granted, provided that the above
+ copyright notice and this permission notice appear in all copies.
+
+ THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
+ IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ """

Makefile

@@ -313,13 +313,13 @@ coverage-run-js:
 .PHONY: test
 # This does not run tests of third-party libraries inside deps.
 test: all ## Runs default tests, linters, and builds docs.
+ $(MAKE) -s tooltest
  $(MAKE) -s test-doc
  $(MAKE) -s build-addons
  $(MAKE) -s build-js-native-api-tests
  $(MAKE) -s build-node-api-tests
  $(MAKE) -s cctest
  $(MAKE) -s jstest
- $(MAKE) -s tooltest
 
 .PHONY: test-only
 test-only: all ## For a quick test, does not run linter or build docs.
@@ -604,7 +604,7 @@ test-doc: doc-only ## Builds, lints, and verifies the docs.
  echo "Skipping test-doc (no crypto)"; \
  else \
  $(MAKE) lint; \
- $(PYTHON) tools/test.py $(PARALLEL_ARGS) $(CI_DOC); \
+ $(PYTHON) tools/test.py $(PARALLEL_ARGS) doctool; \
  fi
 
 test-known-issues: all

README.md

@@ -16,7 +16,6 @@ The Node.js project uses an [open governance model](./GOVERNANCE.md). The
 
 **This project is bound by a [Code of Conduct][].**
 
-
 # Table of Contents
 
 * [Support](#support)
@@ -89,7 +88,6 @@ Version-specific documentation is available in each release directory in the
 _docs_ subdirectory. Version-specific documentation is also at
 <https://nodejs.org/download/docs/>.
 
-
 ### Verifying Binaries
 
 Download directories contain a `SHASUMS256.txt` file with SHA checksums for the
@@ -278,6 +276,8 @@ For information about the governance of the Node.js project, see
 **David Cai** &lt;davidcai1993@yahoo.com&gt; (he/him)
 * [davisjam](https://github.com/davisjam) -
 **Jamie Davis** &lt;davisjam@vt.edu&gt; (he/him)
+* [devnexen](https://github.com/devnexen) -
+**David Carlier** &lt;devnexen@gmail.com&gt;
 * [devsnek](https://github.com/devsnek) -
 **Gus Caplan** &lt;me@gus.host&gt; (he/him)
 * [digitalinfinity](https://github.com/digitalinfinity) -

benchmark/README.md

@@ -83,7 +83,6 @@ See [the guide on writing benchmarks](../doc/guides/writing-and-running-benchmar
 The default benchmarker used to run HTTP benchmarks.
 See [the guide on writing HTTP benchmarks](../doc/guides/writing-and-running-benchmarks.md#creating-an-http-benchmark).
 
-
 ### PORT
 
 The default port used to run HTTP benchmarks.
@@ -95,4 +94,3 @@ Used in special benchmarks that can't use `createBenchmark` and the object
 it returns to accomplish what they need. This function reports timing
 data to the parent process (usually created by running `compare.js`, `run.js` or
 `scatter.js`).
-

benchmark/buffers/buffer-equals.js

@@ -0,0 +1,22 @@
+'use strict';
+const common = require('../common.js');
+
+const bench = common.createBenchmark(main, {
+ size: [0, 512, 16386],
+ difflen: ['true', 'false'],
+ n: [1e6]
+});
+
+function main({ n, size, difflen }) {
+ const b0 = Buffer.alloc(size, 'a');
+ const b1 = Buffer.alloc(size + (difflen === 'true' ? 1 : 0), 'a');
+
+ if (b1.length > 0)
+ b1[b1.length - 1] = 'b'.charCodeAt(0);
+
+ bench.start();
+ for (let i = 0; i < n; i++) {
+ b0.equals(b1);
+ }
+ bench.end(n);
+}

benchmark/events/ee-once.js

@@ -2,18 +2,54 @@
 const common = require('../common.js');
 const EventEmitter = require('events').EventEmitter;
 
-const bench = common.createBenchmark(main, { n: [2e7] });
+const bench = common.createBenchmark(main, {
+ n: [2e7],
+ argc: [0, 1, 4, 5]
+});
 
-function main({ n }) {
+function main({ n, argc }) {
  const ee = new EventEmitter();
 
  function listener() {}
 
- bench.start();
- for (var i = 0; i < n; i += 1) {
- const dummy = (i % 2 === 0) ? 'dummy0' : 'dummy1';
- ee.once(dummy, listener);
- ee.emit(dummy);
+ switch (argc) {
+ case 0:
+ bench.start();
+ for (let i = 0; i < n; i += 1) {
+ const dummy = (i % 2 === 0) ? 'dummy0' : 'dummy1';
+ ee.once(dummy, listener);
+ ee.emit(dummy);
+ }
+ bench.end(n);
+ break;
+ case 1:
+ bench.start();
+ for (let i = 0; i < n; i += 1) {
+ const dummy = (i % 2 === 0) ? 'dummy0' : 'dummy1';
+ ee.once(dummy, listener);
+ ee.emit(dummy, n);
+ }
+ bench.end(n);
+ break;
+ case 4:
+ bench.start();
+ for (let i = 0; i < n; i += 1) {
+ const dummy = (i % 2 === 0) ? 'dummy0' : 'dummy1';
+ ee.once(dummy, listener);
+ ee.emit(dummy, 'foo', argc, 'bar', false);
+ }
+ bench.end(n);
+ break;
+ case 5:
+ bench.start();
+ for (let i = 0; i < n; i += 1) {
+ const dummy = (i % 2 === 0) ? 'dummy0' : 'dummy1';
+ ee.once(dummy, listener);
+ ee.emit(dummy, true, 7.5, 'foo', null, n);
+ }
+ bench.end(n);
+ break;
+ default:
+ throw new Error('Unsupported argument count');
  }
- bench.end(n);
 }

benchmark/misc/getstringwidth.js

@@ -0,0 +1,26 @@
+'use strict';
+
+const common = require('../common.js');
+
+const bench = common.createBenchmark(main, {
+ type: ['ascii', 'mixed', 'emojiseq', 'fullwidth'],
+ n: [10e4]
+}, {
+ flags: ['--expose-internals']
+});
+
+function main({ n, type }) {
+ const { getStringWidth } = require('internal/readline/utils');
+
+ const str = ({
+ ascii: 'foobar'.repeat(100),
+ mixed: 'foo'.repeat(100) + '😀' + 'bar'.repeat(100),
+ emojiseq: '👨‍👨‍👧‍👦👨‍👩‍👦‍👦👨‍👩‍👧‍👧👩‍👩‍👧‍👦'.repeat(10),
+ fullwidth: '你好'.repeat(150)
+ })[type];
+
+ bench.start();
+ for (let j = 0; j < n; j += 1)
+ getStringWidth(str);
+ bench.end(n);
+}