Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] n-api: mark version 5 N-APIs as stable #29458

Closed
wants to merge 1 commit into from
Closed

[v10.x] n-api: mark version 5 N-APIs as stable #29458

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

PR-URL: #29401

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

n-api: mark version 5 N-APIs as stable
fc29c08 
PR-URL: nodejs#29401
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. v10.x labels Sep 5, 2019
@richardlau
Copy link
Member

I suggest updating N-API Version Matrix with a new column for 5 and REPLACEME as the placeholder for the value in the v10.x row.

@gabrielschulhof
Copy link
Contributor Author

@richardlau I created #29461 which I can then backport. Is that how you envisioned it?

@mhdawson
Copy link
Member

mhdawson commented Sep 5, 2019

@gabrielschulhof, @richardlau not sure if a PR with REPLACEME's for all of the version make sense as I don't think you'll be able to land until those are replaced or they might get replaced with the wrong version?

mhdawson
mhdawson approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau
Copy link
Member

I envision that each backport would have a single REPLACEME in the appropriate row so that when the release is later cut it is replaced with the version being released as part of the release process: https://github.com/nodejs/node/blob/master/doc/releases.md#step-3-update-any-replaceme-and-dep00xx-tags-in-the-docs

@gabrielschulhof gabrielschulhof mentioned this pull request Sep 9, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25583/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 19, 2019 •
edited by BethGriggs
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/25585/ ✅

@mhdawson
Copy link
Member

@BethGriggs I assume this will be part of the next 10.x SemVer minor?

BethGriggs pushed a commit that referenced this pull request Oct 1, 2019
@BethGriggs
n-api: mark version 5 N-APIs as stable
c74c6a5 
PR-URL: #29401
Backport-PR-URL: #29458
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BethGriggs
Copy link
Member

Landed on v10.x-staging

@BethGriggs BethGriggs closed this Oct 1, 2019
@gabrielschulhof gabrielschulhof deleted the backport-29401-to-v10.x branch March 13, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gabrielschulhof @richardlau @mhdawson @nodejs-github-bot @BethGriggs