Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove the suffix number of the anchor link #29468

Closed
wants to merge 1 commit into from
Closed

doc: remove the suffix number of the anchor link #29468

wants to merge 1 commit into from

Conversation

SEWeiTung
Copy link

Remove the number '11' as the suffix anchor id for the 'Developer's Certificate of Origin 1.1'.

Ref: #6257

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

doc: remove the suffix number of the anchor link
6446e99 
Remove the number '11' as the suffix anchor id for the 'Developer's
Certificate of Origin 1.1'.

Ref: #6257.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 6, 2019
@danbev
Copy link
Contributor

danbev commented Sep 9, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3899/

@SEWeiTung
Copy link
Author

@Trott, maybe this can be merged...?

@Trott
Copy link
Member

Trott commented Sep 22, 2019

Landed in 872d803

Trott pushed a commit that referenced this pull request Sep 22, 2019
@Trott
doc: remove the suffix number of the anchor link
872d803 
Remove the number '11' as the suffix anchor id for the 'Developer's
Certificate of Origin 1.1'.

PR-URL: #29468
Refs: #6257
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott closed this Sep 22, 2019
@SEWeiTung SEWeiTung deleted the removeLink branch September 23, 2019 01:22
targos pushed a commit that referenced this pull request Sep 23, 2019
@targos
doc: remove the suffix number of the anchor link
6792e11 
Remove the number '11' as the suffix anchor id for the 'Developer's
Certificate of Origin 1.1'.

PR-URL: #29468
Refs: #6257
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@BridgeAR
doc: remove the suffix number of the anchor link
13d173f 
Remove the number '11' as the suffix anchor id for the 'Developer's
Certificate of Origin 1.1'.

PR-URL: #29468
Refs: #6257
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SEWeiTung @danbev @Trott @jasnell @devnexen @nodejs-github-bot