Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 7.7.299.10 #29472

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 7.7.299.10 #29472

wants to merge 1 commit into from

Conversation

Hakerh400
Copy link
Contributor

Fixes #29462

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Sep 6, 2019
@targos
Copy link
Member

targos commented Sep 6, 2019

This fix was backmerged in 7.7-lkgr: https://github.com/v8/v8/commits/7.7-lkgr.
Could you update V8 to the latest version instead?
The command is git node v8 minor.

@Hakerh400 Hakerh400 changed the title deps: V8: cherry-pick 1990b1e deps: patch V8 to 7.7.299.10 Sep 6, 2019
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 6, 2019

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member

targos commented Sep 20, 2019

Landed in dc7c7b8

@targos targos closed this Sep 20, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
Refs: v8/v8@7.7.299.8...7.7.299.10

PR-URL: #29472
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@Hakerh400 Hakerh400 deleted the reg branch September 20, 2019 08:28
targos pushed a commit that referenced this pull request Sep 23, 2019
Refs: v8/v8@7.7.299.8...7.7.299.10

PR-URL: #29472
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
Refs: v8/v8@7.7.299.8...7.7.299.10

PR-URL: #29472
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targos targos mentioned this pull request Oct 22, 2019
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regexp lookBehind bug?
5 participants