Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: make terminate() resolve for unref’ed Workers #29484

Closed
wants to merge 1 commit into from
Closed

worker: make terminate() resolve for unref’ed Workers #29484

wants to merge 1 commit into from

Commits on Sep 7, 2019

  1. worker: make terminate() resolve for unref’ed Workers 

    Once `worker.terminate()` is called, the Worker instance will be
destroyed as soon as possible anyway, so in order to make
the Promise returned by `worker.terminate()` resolve always,
it should be okay to just call `.ref()` on it and keep the main
event loop alive temporarily.
    @addaleax
    addaleax committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    dd873e2 View commit details
    Browse the repository at this point in the history