-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: indenting child list items for remark-lint #29488
Closed
nschonni
wants to merge
1
commit into
nodejs:master
from
nschonni:doc--indenting-child-list-items-for-remak-lint
Closed
doc: indenting child list items for remark-lint #29488
nschonni
wants to merge
1
commit into
nodejs:master
from
nschonni:doc--indenting-child-list-items-for-remak-lint
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Sep 8, 2019
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Sep 8, 2019
doh, I just noticed that I misspelled "remark" in the commit message when i got the GitHub notification. |
Child items not aligned to parent are flagged by list-item-bullet-indent
nschonni
force-pushed
the
doc--indenting-child-list-items-for-remak-lint
branch
from
September 8, 2019 02:44
e0df69a
to
a2bac24
Compare
cjihrig
approved these changes
Sep 8, 2019
Note for whoever lands this: |
trivikr
approved these changes
Sep 9, 2019
Landed in f615285 |
Trott
pushed a commit
that referenced
this pull request
Sep 10, 2019
Child items not aligned to parent are flagged by list-item-bullet-indent PR-URL: #29488 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
nschonni
changed the title
doc: indenting child list items for remak-lint
doc: indenting child list items for remark-lint
Sep 11, 2019
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Child items not aligned to parent are flagged by list-item-bullet-indent PR-URL: #29488 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
Child items not aligned to parent are flagged by list-item-bullet-indent PR-URL: #29488 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes