Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: indenting child list items for remark-lint #29488

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Sep 7, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 7, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 8, 2019
@nschonni
Copy link
Member Author

nschonni commented Sep 8, 2019

doh, I just noticed that I misspelled "remark" in the commit message when i got the GitHub notification.
I'll push a quick commit message fix

@Trott
Copy link
Member

Trott commented Sep 8, 2019

Child items not aligned to parent are flagged by list-item-bullet-indent
@nschonni nschonni force-pushed the doc--indenting-child-list-items-for-remak-lint branch from e0df69a to a2bac24 Compare September 8, 2019 02:44
@Trott
Copy link
Member

Trott commented Sep 8, 2019

@Trott
Copy link
Member

Trott commented Sep 8, 2019

Note for whoever lands this: s/indenting/indent/ for the first line of the commit message.

@Trott
Copy link
Member

Trott commented Sep 10, 2019

Landed in f615285

@Trott Trott closed this Sep 10, 2019
Trott pushed a commit that referenced this pull request Sep 10, 2019
Child items not aligned to parent are flagged by list-item-bullet-indent

PR-URL: #29488
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@nschonni nschonni deleted the doc--indenting-child-list-items-for-remak-lint branch September 10, 2019 13:30
@nschonni nschonni changed the title doc: indenting child list items for remak-lint doc: indenting child list items for remark-lint Sep 11, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
Child items not aligned to parent are flagged by list-item-bullet-indent

PR-URL: #29488
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
Child items not aligned to parent are flagged by list-item-bullet-indent

PR-URL: #29488
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants