stream: don't call _read after destroy() #29491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
ronag
force-pushed
the
no-read-after-destroy
branch
3 times, most recently
from
0b2d7a0
to
c65a3a3
Compare
|
@Trott: I'm a little confused. That test does not fail for me locally? |
benjamingr
approved these changes
Sep 8, 2019
ronag
force-pushed
the
no-read-after-destroy
branch
from
c65a3a3
to
4f09ffc
Compare
JungMinu
approved these changes
Sep 9, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Sep 11, 2019
ronag
force-pushed
the
no-read-after-destroy
branch
from
4f09ffc
to
fd8f2b6
Compare
lpinca
approved these changes
Sep 12, 2019
|
There seem to be some tests failures/regressions on specific environments :/. |
|
@Trott: This looks ready? |
benjamingr
added
the
author ready
Fishrock123
approved these changes
Sep 22, 2019
Trott
pushed a commit
that referenced
this pull request
Sep 22, 2019
PR-URL: #29491 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Landed in ec390b6 |
targos
pushed a commit
that referenced
this pull request
Sep 23, 2019
PR-URL: #29491 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
PR-URL: #29491 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes #29477.
Currently stream implementations MUST check for destroyed inside _read.
Found this while investigating a suspicious
destroyedconditional in fs streams."Full" fix in #29485 but it is way too breaking at this point and needs more updated tests.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes