Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make full-icu the default #29522

Closed
wants to merge 2 commits into from
Closed

Make full-icu the default #29522

wants to merge 2 commits into from
+195 −135

Commits on Sep 30, 2019

  1. tools: tooling/data for supporting full-icu by default 

    Instead of an English-only icudt64l.dat in the repo,
we now have icudt64l.dat.gz with all locales.

- updated READMEs and docs
- shrinker now copies source, and compresses (bzip2) the ICU data file
- configure expects deps/icu-small to be full ICU with a full
compressed data file

Fixes: nodejs#19214
Co-Authored-By: Richard Lau <riclau@uk.ibm.com>
Co-Authored-By: Jan Olaf Krems <jan.krems@gmail.com>
Co-Authored-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#29522
    @srl295 @richardlau
    @jkrems @jasnell
    4 people committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    7b1e862 View commit details
    Browse the repository at this point in the history

  2. fixup! tools: tooling/data for supporting full-icu by default

    @srl295
    srl295 committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    b8562ed View commit details
    Browse the repository at this point in the history