repl: declare for initial expression in the for loop, instead of hoisting and re-using #29535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a to a variable declaration in a for loop that wasn't using anything.
|
The loop is using a previously declared |
|
@mscdex ah, i see it. however, it is not consistent with how the other loops are doing things. And it is also going across functions which seems wrong. I also realize this code base dates back a while, but i think we can start to clean things up like this, when hoisting all your variables to the top of the function was the thing to do perhaps the title of the issue could change to better reflect what is being done? I also saw a couple more for loops where that variable was being used. i'm going to update the PR with those also. |
i missed a couple in the previous commit. this also removes the hoisted variable that was being used for those loops This can be squashed
lholmquist
changed the title
addaleax
approved these changes
Sep 12, 2019
trivikr
approved these changes
Sep 12, 2019
|
@lholmquist Personally, I think a separate commit is fine, given that that reduces the likelihood of merge conflicts with this PR. Others may feel differently, though. |
|
@addaleax thanks for the tip. I might just wait until this is merged, then send another PR(referencing this one), just so it doesn't clutter this PR to much |
devnexen
approved these changes
Sep 13, 2019
cjihrig
approved these changes
Sep 13, 2019
|
Landed in 30e919a |
Trott
pushed a commit
that referenced
this pull request
Sep 14, 2019
* Adds `let` to a variable declaration in a for loop that wasn't using anything. * Declare the for initial expression in the for loop. * Remove hoisted variables for loops. PR-URL: #29535 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
lholmquist
added a commit
to lholmquist/node
that referenced
this pull request
Sep 16, 2019
* This goes along with the PR, nodejs#29535, that started to clean up the repl module. This PR replaces the instances of var with let/const.
2 tasks
Trott
pushed a commit
that referenced
this pull request
Sep 19, 2019
Refs: #29535 This PR replaces the instances of var with let/const. PR-URL: #29575 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
* Adds `let` to a variable declaration in a for loop that wasn't using anything. * Declare the for initial expression in the for loop. * Remove hoisted variables for loops. PR-URL: #29535 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Refs: #29535 This PR replaces the instances of var with let/const. PR-URL: #29575 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
* Adds `let` to a variable declaration in a for loop that wasn't using anything. * Declare the for initial expression in the for loop. * Remove hoisted variables for loops. PR-URL: #29535 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
Refs: #29535 This PR replaces the instances of var with let/const. PR-URL: #29575 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 25, 2019
This was referenced Sep 26, 2019
This was referenced May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a for loop that had an initial Expression that wasn't using let/var, this adds a
letto itI also noticed that this module uses var instead of let/const. I saw in another issue,#28009 (comment) , the reasoning for why they haven't been updated yet. But since i am touching this file, I would like to try to do the conversion for this file. If someone else agrees i can push another commit with those updates, if not, then i'll just keep this PR as is
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes