Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-inspector-connect-main-thread #29588

Closed
wants to merge 2 commits into from

Commits on Sep 16, 2019

  1. doc: update experimental loader hooks example code

    It fix 2 issues in provided Loader hooks examples:
    1. Original ``new URL(`${process.cwd()}/`, 'file://');``
    is not cross-platform, it gives wrong URL on windows
    2. Based on `CHECK` in ModuleWrap::Resolve (node 12.9.1,
    https://github.com/nodejs/node/blob/v12.9.1/src/module_wrap.cc#L1132)
    the 2nd parameter should be a `string`, not an `URL` object
    
    PR-URL: nodejs#29373
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    zaverden authored and devnexen committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    1ecc406 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2019

  1. test: fix flaky test-inspector-connect-main-thread

    Using `console.log()` likely interferes with the functionality of the
    test, which also checks the interaction between inspector
    and `console.log()` as part of the test. Using `process._rawDebug()`
    solves that issue.
    
    Refs: nodejs#28870
    Refs: nodejs#29582
    addaleax committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    b1314e0 View commit details
    Browse the repository at this point in the history