Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.x] doc: update N-API version matrix #29600

Closed
wants to merge 1 commit into from
Closed

[12.x] doc: update N-API version matrix #29600

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Sep 18, 2019 •
edited
Loading

PR-URL: #29461

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

doc: update N-API version matrix
3d7d694 
PR-URL: nodejs#29461
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. v12.x labels Sep 18, 2019
@gabrielschulhof gabrielschulhof mentioned this pull request Sep 18, 2019
Closed
@gabrielschulhof
Copy link
Contributor Author

Note: #29401 ought to be backported first. It should apply cleanly to v12.x.

@richardlau richardlau mentioned this pull request Sep 24, 2019
Merged
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25682/

@BridgeAR
Copy link
Member

Landed on staging: 325de43

@BridgeAR BridgeAR closed this Sep 25, 2019
@gabrielschulhof gabrielschulhof deleted the backport-29461-to-12.x branch March 13, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gabrielschulhof @nodejs-github-bot @BridgeAR @lpinca @gengjiawen @richardlau