build,win: goto lint only after defining node_exe #29616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `vcbuild lint` on a new prompt where vcbuild was not run before, `%node_exe%` was not defined and `eslint.js`, `lint-js.js` and `lint-md.js` would be run directly using the program defined in Windows (usually the Windows Scripting Host or Notepad). This moves the goto statement to after `%node_exe%` is defined. Fixes: nodejs#29602
joaocgreis
added
windows
|
@bzmlxos did you compile Node by running just Running the C++ requires having either WSL installed or a copy of GNU Make in the path. |
|
Using GNU Make is a workaround we have in place (ref #28102), a better solution would use Python to run the same code on all platforms.
@bzmlxos the error you see is because the Unix tools that Git installs are not on the PATH. You need to either:
|
|
@nodejs/platform-windows @nodejs/build-files this is ready for review, PTAL. |
BridgeAR
approved these changes
Sep 23, 2019
Trott
added
the
author ready
|
Landed in 35bfe0e |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Sep 27, 2019
When running `vcbuild lint` on a new prompt where vcbuild was not run before, `%node_exe%` was not defined and `eslint.js`, `lint-js.js` and `lint-md.js` would be run directly using the program defined in Windows (usually the Windows Scripting Host or Notepad). This moves the goto statement to after `%node_exe%` is defined. Fixes: nodejs#29602 PR-URL: nodejs#29616 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Oct 1, 2019
When running `vcbuild lint` on a new prompt where vcbuild was not run before, `%node_exe%` was not defined and `eslint.js`, `lint-js.js` and `lint-md.js` would be run directly using the program defined in Windows (usually the Windows Scripting Host or Notepad). This moves the goto statement to after `%node_exe%` is defined. Fixes: #29602 PR-URL: #29616 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
vcbuild linton a new command prompt wherevcbuildwas not run before,%node_exe%was not defined andeslint.js,lint-js.jsandlint-md.jswould be run directly using the program defined in Windows (usually the Windows Scripting Host or Notepad).This moves the goto statement to after
%node_exe%is defined.Fixes: #29602
cc @nodejs/platform-windows
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes