-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: _write optional when _writev #29639
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
Issues and PRs related to the stream subsystem.
label
Sep 20, 2019
ronag
force-pushed
the
fix-writable-write-opt
branch
2 times, most recently
from
September 20, 2019 23:31
9291d9f
to
813928e
Compare
When implementing _writev, _write should be optional.
ronag
force-pushed
the
fix-writable-write-opt
branch
from
September 20, 2019 23:33
813928e
to
757de53
Compare
addaleax
reviewed
Sep 20, 2019
addaleax
added
the
semver-minor
PRs that contain new features and should be released in the next minor version.
label
Sep 20, 2019
ronag
force-pushed
the
fix-writable-write-opt
branch
from
September 20, 2019 23:45
8afeca9
to
c039515
Compare
addaleax
approved these changes
Sep 20, 2019
JungMinu
approved these changes
Sep 21, 2019
lpinca
approved these changes
Sep 21, 2019
@@ -558,7 +558,11 @@ function clearBuffer(stream, state) { | |||
} | |||
|
|||
Writable.prototype._write = function(chunk, encoding, cb) { | |||
cb(new ERR_METHOD_NOT_IMPLEMENTED('_write()')); | |||
if (this._writev) { | |||
this._writev([{ chunk, encoding }], cb); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this introduces a small performance penalty but the user can implement _write()
to avoid it.
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Sep 22, 2019
Landed in d398b8f |
Trott
pushed a commit
that referenced
this pull request
Sep 23, 2019
When implementing _writev, _write should be optional. PR-URL: #29639 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 23, 2019
When implementing _writev, _write should be optional. PR-URL: #29639 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
added a commit
that referenced
this pull request
Sep 24, 2019
Notable changes: * crypto: * Add `oaepLabel` option #29489 * deps: * Update V8 to 7.7.299.11 #28918 * More efficient memory handling * Stack trace serialization got faster * The `Intl.NumberFormat` API gained new functionality * For more information: https://v8.dev/blog/v8-release-77 * events: * Add support for `EventTarget` in `once` #29498 * fs: * Expose memory file mapping flag `UV_FS_O_FILEMAP` #29260 * inspector: * New API - `Session.connectToMainThread` #28870 * process: * Initial SourceMap support via `env.NODE_V8_COVERAGE` #28960 * stream: * Make `_write()` optional when `_writev()` is implemented #29639 * tls: * Add option to override signature algorithms #29598 * util: * Add `encodeInto` to `TextEncoder` #29524 * worker: * The `worker_thread` module is now stable #29512
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
When implementing _writev, _write should be optional. PR-URL: #29639 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
added a commit
that referenced
this pull request
Sep 25, 2019
Notable changes: * crypto: * Add `oaepLabel` option #29489 * deps: * Update V8 to 7.7.299.11 #28918 * More efficient memory handling * Stack trace serialization got faster * The `Intl.NumberFormat` API gained new functionality * For more information: https://v8.dev/blog/v8-release-77 * events: * Add support for `EventTarget` in `once` #29498 * fs: * Expose memory file mapping flag `UV_FS_O_FILEMAP` #29260 * inspector: * New API - `Session.connectToMainThread` #28870 * process: * Initial SourceMap support via `env.NODE_V8_COVERAGE` #28960 * stream: * Make `_write()` optional when `_writev()` is implemented #29639 * tls: * Add option to override signature algorithms #29598 * util: * Add `encodeInto` to `TextEncoder` #29524 * worker: * The `worker_thread` module is now stable #29512 PR-URL: #29695
BridgeAR
added a commit
that referenced
this pull request
Sep 25, 2019
Notable changes: * crypto: * Add `oaepLabel` option #29489 * deps: * Update V8 to 7.7.299.11 #28918 * More efficient memory handling * Stack trace serialization got faster * The `Intl.NumberFormat` API gained new functionality * For more information: https://v8.dev/blog/v8-release-77 * events: * Add support for `EventTarget` in `once` #29498 * fs: * Expose memory file mapping flag `UV_FS_O_FILEMAP` #29260 * inspector: * New API - `Session.connectToMainThread` #28870 * process: * Initial SourceMap support via `env.NODE_V8_COVERAGE` #28960 * stream: * Make `_write()` optional when `_writev()` is implemented #29639 * tls: * Add option to override signature algorithms #29598 * util: * Add `encodeInto` to `TextEncoder` #29524 * worker: * The `worker_thread` module is now stable #29512 PR-URL: #29695
This was referenced Sep 25, 2019
This was referenced Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
semver-minor
PRs that contain new features and should be released in the next minor version.
stream
Issues and PRs related to the stream subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing _writev, _write should be optional.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes