-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: fix closing weak HandleWrap
s on GC
#29640
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs#29317
nodejs-github-bot
added
the
c++
Issues and PRs that require attention from people who are familiar with C++.
label
Sep 21, 2019
bcoe
approved these changes
Sep 21, 2019
This currently breaks CI for the unrelated #28960, so feel free to 👍 this comment to approve fast-tracking. |
addaleax
added
fast-track
PRs that do not need to wait for 48 hours to land.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Sep 21, 2019
Trott
reviewed
Sep 21, 2019
Trott
approved these changes
Sep 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question but nothing that should block this from landing and fixing CI. My comment can be addressed in another PR or not at all.
bcoe
approved these changes
Sep 21, 2019
Landed in e74f308 |
Merged
This was referenced Sep 25, 2019
addaleax
added a commit
to nodejs/quic
that referenced
this pull request
Sep 29, 2019
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs/node#29317 PR-URL: nodejs/node#29640 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell
pushed a commit
to nodejs/quic
that referenced
this pull request
Oct 1, 2019
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs/node#29317 PR-URL: nodejs/node#29640 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
added a commit
to nodejs/quic
that referenced
this pull request
Oct 2, 2019
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs/node#29317 PR-URL: nodejs/node#29640 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell
pushed a commit
to nodejs/quic
that referenced
this pull request
Oct 2, 2019
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs/node#29317 PR-URL: nodejs/node#29640 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.
Thanks to @bcoe for pointing me to this as the cause of the failure in https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd11-x64/28455/console.
Refs: #29317
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes