stream: remove ambiguous code #29664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
s/ambigious/ambiguous/ in commit message |
ronag
force-pushed
the
stream-eos-dead
branch
from
2971a38
to
67be60d
Compare
|
Not sure what you meant. But I'm guess it's the misspelling. Fixed. |
4 tasks
JungMinu
approved these changes
Sep 29, 2019
JungMinu
pushed a commit
that referenced
this pull request
Sep 29, 2019
PR-URL: #29664 Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
Landed in ce62e96 |
BridgeAR
added
backport-requested-v12.x
stream
|
@ronag I guess this depends on other PRs that need backporting first? This currently causes conflicts that are not obvious to resolve. Would you be so kind and check if other PRs need backporting first and add that as well / open a backport if you think that's useful here? |
|
This is probably about to be reverted in #29717 (comment). I will look into backporting this if/when this becomes relevant again. |
|
quick ping re: backport |
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Jan 18, 2020
PR-URL: nodejs#29664 Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
sxa
pushed a commit
to sxa/node
that referenced
this pull request
Jan 24, 2020
PR-URL: nodejs#29664 Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
@MylesBorins In view of 8c60685#diff-009356850b536cab27b019ba8ad15e72 are you sure this should be backported? |
|
Seems like it shouldn't |
This was referenced May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some ambiguous code. I don't believe this actually causes any observable change of behaviour.
writable,readableis supposed to indicate the type of the stream, which does not change... this PR makes the code less confusingChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes