Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix tls version values #29839

Closed
wants to merge 2 commits into from
Closed

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Oct 4, 2019

Some of these values are formatted as strings, fix the formatting of the newer values.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Oct 4, 2019
@richardlau
Copy link
Member

Could you also fix up the similar values in tls.DEFAULT_MAX_VERSION?

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 4, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25839/

(I kicked off CLI because I'm curious if the main branch is currently flapping for some builds; seems like I'd bumped in to a blip).

@danbev danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 8, 2019
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

tniessen added a commit that referenced this pull request Oct 10, 2019
PR-URL: #29839
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@tniessen
Copy link
Member Author

Landed in 36e83ef, thanks for reviewing!

@tniessen tniessen closed this Oct 10, 2019
targos pushed a commit that referenced this pull request Oct 14, 2019
PR-URL: #29839
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.