Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: IncomingMessage destroyed state #29855

Closed
wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Oct 6, 2019

IncomingMessage should implement _destroy() instead of overriding
destroy() in order to behave properly like a stream.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Oct 6, 2019
IncomingMessage should implement _destroy() instead of overriding
destroy() in order to behave properly like a stream.
@ronag
Copy link
Member Author

ronag commented Oct 6, 2019

This was supposed to go to my own fork.

@ronag ronag closed this Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants