Gyp Python 3 fixes for Windows

[targos]

Commits:

tools: port Python 3 compat patches from node-gyp to gyp

Refs: https://github.com/nodejs/node-gyp/pull/1820
Refs: https://github.com/nodejs/node-gyp/pull/1843


build: always use strings for compiler version in gyp files

If GYP finds a string variable that can be converted to an integer,
it will do it when the variable is expanded. Use "0.0" instead of "0"
to force strings and be able to use comparison operations such as
`gas_version >= "2.26"` in Python 3.


tools: fix GYP MSVS solution generator for Python 3

/cc @nodejs/python

[targos]

Note: with this change and #29898, I'm able to build Node on Windows with VS 2019 and Python 3.7.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/25919/

[sam-github]

Does tools: fix GYP MSVS solution generator for Python 3 needs to be ported back to node-gyp?

I'd RSLGTM it, but it failed in CI. I resumed in case the failures were ephemeral.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/25925/

[richardlau]

Use "0.0" instead of "0" to force strings and be able to use comparison operations such as
gas_version >= "2.26" in Python 3.

Is that a safe comparison? e.g. What if gas_version is "2.3"?

[targos]

Use "0.0" instead of "0" to force strings and be able to use comparison operations such as
gas_version >= "2.26" in Python 3.

Is that a safe comparison? e.g. What if gas_version is "2.3"?

I have no idea. gas_version has always been string like that, unless it had the integer value 0.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/25954/

[sam-github]

I'd be willing to rubber stamp this once @cclauss or someone more up to date on python weighs in.

Once question, @targos , is this CI-able? Do we have a windows CI machine with py3? I think that even if it did, we might currently "prefer" py2, so mere existence of py3 isn't enough yet.

I wonder, can Travis do a py3-only windows build?

[targos]

is this CI-able? Do we have a windows CI machine with py3?

I don't know. I could try to add a github action to this PR that runs on Windows and remove it before landing.

• py2 is tested in our CI and the results are OK
• py3 was tested by me on my PC

[sam-github]

If py3 works for you, that's good enough for now -- adding and removing an action to prove it isn't necessary from my perspective.

[cclauss]

can Travis do a py3-only windows build?
Yes.

[cclauss]

Nice! Thanks for this.

[targos]

Landed in 7de5a55...8728f86