Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify unshift EOF #29950

Closed
wants to merge 2 commits into from
Closed

doc: clarify unshift EOF #29950

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f73edf
stream: clearify readable.unshift null
ronag Oct 16, 2019
e184520
doc: clarify unshift EOF
ronag Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,8 +1288,10 @@ changes:
* `encoding` {string} Encoding of string chunks. Must be a valid
`Buffer` encoding, such as `'utf8'` or `'ascii'`.

Passing `chunk` as `null` signals the end of the stream (EOF), after which no
more data can be written.
Passing `chunk` as `null` signals the end of the stream (EOF) and behaves the
same as `readable.push(null)`, after which no more data can be written. Note
that the EOF signal is put at the end of the buffer and any buffered data will
still be flushed.
ronag marked this conversation as resolved.
Show resolved Hide resolved

The `readable.unshift()` method pushes a chunk of data back into the internal
buffer. This is useful in certain situations where a stream is being consumed by
Expand Down