Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: test Python 3.7 on Travis CI AGAIN #29985

Closed
wants to merge 3 commits into from
Closed

build: test Python 3.7 on Travis CI AGAIN #29985

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cfa680
build: test Python 3.7 on Travis CI AGAIN
cclauss Oct 15, 2019
a21a04d
fixup: Upgrade to Python 3.8
cclauss Oct 15, 2019
3f9b77b
Revert from Python 3.8 back to 3.7
cclauss Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@ language: cpp
# To experiment with Python 3, comment out Python 2.7 and uncomment one of the Python 3 versions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind switching the Python on Travis to Python 3 (assuming everything works). If so this comment can go.

env:
global:
- PYTHON_VERSION="2.7.15"
# - PYTHON_VERSION="2.7.15"
# - PYTHON_VERSION="3.6.7"
# - PYTHON_VERSION="3.7.1"
- PYTHON_VERSION="3.7.1"
- PYTHON=python3
- EXPERIMENTAL_NODE_GYP_PYTHON3="yes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget, is EXPERIMENTAL_NODE_GYP_PYTHON3 still required for node-gyp 5.x?

jobs:
include:
- stage: "Compile"
Expand Down