Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: build benchmark addons like test addons #29995

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

richardlau
Copy link
Member

Build the addons for benchmarks in the same way that the addons for
tests are built.

Fixes: nodejs/build#1961
Refs: 53ca0b9#commitcomment-35494896

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 16, 2019
richardlau referenced this pull request Oct 16, 2019
Since worker threads are complete Node.js environments, including the
ability to load native addons, and since those native addons can
allocate resources to be freed when objects go out of scope, and since,
upon worker thread exit, the engine does not invoke the weak callbacks
responsible for freeing resources which still have references, this
modification introduces tracking for weak references such that a list
of outstanding weak references is maintained. This list is traversed
during environment teardown. The callbacks for the remaining weak
references are called.

This change is also relevant for Node.js embedder scenarios, because in
those cases the process also outlives the `node::Environment` and
therefore weak callbacks should also be rendered as environment cleanup
hooks to ensure proper cleanup after native addons. This changes
introduces the means by which this can be accomplished.

A benchmark is included which measures the time it takes to execute the
weak reference callback for a given number of weak references.

Re: tc39/proposal-weakrefs#125 (comment)
PR-URL: #28428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@richardlau
Copy link
Member Author

cc @nodejs/n-api @nodejs/build-files @Trott

@richardlau richardlau added benchmark Issues and PRs related to the benchmark subsystem. addons Issues and PRs related to native addons. node-api Issues and PRs related to the Node-API. labels Oct 16, 2019
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member Author

richardlau commented Oct 16, 2019

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2019
@Trott
Copy link
Member

Trott commented Oct 16, 2019

I propose fast-tracking this to un-break nightly CI. Collaborators, please 👍 here if you agree. Thanks!

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 16, 2019
@richardlau
Copy link
Member Author

Going to step away from my computer for a bit.

Still waiting for https://ci.nodejs.org/job/node-test-commit-arm/26747/nodes=debian9-docker-armv7/ to complete (it was queued for four hours waiting for a free debian9-docker-armv7 host (at one point two of the three were disconnected) and has been running for 2+hours (and seems very slow)) but otherwise this looks landable assuming the remaining job comes back non-red.

Build the addons for benchmarks in the same way that the addons for
tests are built.

PR-URL: nodejs#29995
Fixes: nodejs/build#1961
Refs: nodejs@53ca0b9#commitcomment-35494896
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau
Copy link
Member Author

Landed in c8df5cf.

@richardlau richardlau deleted the bench branch October 17, 2019 05:40
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Oct 22, 2019
Build the addons for benchmarks in the same way that the addons for
tests are built.

PR-URL: nodejs#29995
Fixes: nodejs/build#1961
Refs: nodejs@53ca0b9#commitcomment-35494896
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
Build the addons for benchmarks in the same way that the addons for
tests are built.

PR-URL: #29995
Fixes: nodejs/build#1961
Refs: 53ca0b9#commitcomment-35494896
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
Build the addons for benchmarks in the same way that the addons for
tests are built.

PR-URL: #29995
Fixes: nodejs/build#1961
Refs: 53ca0b9#commitcomment-35494896
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 23, 2019
targos pushed a commit that referenced this pull request Nov 8, 2019
Build the addons for benchmarks in the same way that the addons for
tests are built.

PR-URL: #29995
Fixes: nodejs/build#1961
Refs: 53ca0b9#commitcomment-35494896
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
Build the addons for benchmarks in the same way that the addons for
tests are built.

PR-URL: #29995
Fixes: nodejs/build#1961
Refs: 53ca0b9#commitcomment-35494896
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node-daily-master always fails due to napi test in node-test-commit-custom-suite-freestyle
6 participants