Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update collaborator email address #30007

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Conversation

JungMinu
Copy link
Member

update my personal email in README

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 17, 2019
@JungMinu JungMinu self-assigned this Oct 17, 2019
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have any commits with the old email address you can optionally remap them in https://github.com/nodejs/node/blob/master/.mailmap for the purposes of the AUTHORS file.

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 17, 2019
@JungMinu JungMinu changed the title meta: update personal info doc: update collaborator email address Oct 19, 2019
update collaborator email address

PR-URL: nodejs#30007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@JungMinu JungMinu merged commit 425357a into nodejs:master Oct 19, 2019
@JungMinu JungMinu deleted the meta branch October 19, 2019 05:26
@JungMinu
Copy link
Member Author

Landed in 425357a

MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
update collaborator email address

PR-URL: #30007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
update collaborator email address

PR-URL: #30007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 23, 2019
targos pushed a commit that referenced this pull request Nov 8, 2019
update collaborator email address

PR-URL: #30007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
update collaborator email address

PR-URL: #30007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2019
update collaborator email address

PR-URL: #30007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants