Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: make YAML matter consistent in crypto.md #30016

Merged
merged 1 commit into from
Oct 18, 2019
Merged

doc: make YAML matter consistent in crypto.md #30016

merged 1 commit into from
Oct 18, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 18, 2019

This fixes YAML that gets incorrectly processed by our tooling.

Refs: #29910 (comment)

@vsemozhetbyt

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Oct 18, 2019
@Trott
Copy link
Member Author

Trott commented Oct 18, 2019

Collaborators, please 👍 here to fast-track.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 18, 2019
@Trott
Copy link
Member Author

Trott commented Oct 18, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 18, 2019
@richardlau
Copy link
Member

We should (in another PR) make the tooling throw some sort of error on the original YAML rather than silently incorrectly process it and rely on a human eyeballing the generated docs.

@Trott
doc: make YAML matter consistent in crypto.md
ce72cd7 
This fixes YAML that gets incorrectly processed by our tooling.

Refs: nodejs#29910 (comment)

PR-URL: nodejs#30016
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott
Copy link
Member Author

Trott commented Oct 18, 2019

Landed in ce72cd7

@Trott Trott merged commit ce72cd7 into nodejs:master Oct 18, 2019
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
@Trott @MylesBorins
doc: make YAML matter consistent in crypto.md
038dfc4 
This fixes YAML that gets incorrectly processed by our tooling.

Refs: #29910 (comment)

PR-URL: #30016
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
@Trott @MylesBorins
doc: make YAML matter consistent in crypto.md
39070bb 
This fixes YAML that gets incorrectly processed by our tooling.

Refs: #29910 (comment)

PR-URL: #30016
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request Nov 5, 2019
Merged
@targos
Copy link
Member

targos commented Nov 8, 2019

Depends on #29910 to land on v12.x

targos pushed a commit that referenced this pull request Jan 8, 2020
@Trott @targos
doc: make YAML matter consistent in crypto.md
4088546 
This fixes YAML that gets incorrectly processed by our tooling.

Refs: #29910 (comment)

PR-URL: #30016
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Jan 8, 2020
@Trott @targos
doc: make YAML matter consistent in crypto.md
4e8b8bc 
This fixes YAML that gets incorrectly processed by our tooling.

Refs: #29910 (comment)

PR-URL: #30016
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Trott @BethGriggs
doc: make YAML matter consistent in crypto.md
426ed0d 
This fixes YAML that gets incorrectly processed by our tooling.

Refs: #29910 (comment)

PR-URL: #30016
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
@Trott Trott deleted the fix-yaml-processing branch January 13, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @richardlau @targos @jasnell @cjihrig @gireeshpunathil @nodejs-github-bot