Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test runner for Python 3 on Windows #30023

Closed
wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 18, 2019

Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

/cc @nodejs/python

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Oct 18, 2019
richardlau
richardlau previously approved these changes Oct 18, 2019
@richardlau richardlau dismissed their stale review October 18, 2019 10:42

Doesn’t seem to be compatible with Python 2

@cclauss
Copy link
Contributor

cclauss commented Oct 18, 2019

On legacy Python, this will raise:
TypeError: 'encoding' is an invalid keyword argument for this function

@targos
Copy link
Member Author

targos commented Oct 18, 2019

How can we make it compatible with legacy Python?

@cclauss
Copy link
Contributor

cclauss commented Oct 18, 2019

https://github.com/pypa/sampleproject/blob/master/setup.py#L15

Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.
@nodejs-github-bot
Copy link
Collaborator

@sam-github sam-github added the python PRs and issues that require attention from people who are familiar with Python. label Oct 18, 2019
@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 19, 2019
@targos
Copy link
Member Author

targos commented Oct 20, 2019

Landed in a4e075f

@targos targos closed this Oct 20, 2019
@targos targos deleted the py3-win-test branch October 20, 2019 14:06
targos added a commit that referenced this pull request Oct 20, 2019
Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

PR-URL: #30023
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

PR-URL: #30023
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

PR-URL: #30023
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 23, 2019
targos added a commit that referenced this pull request Nov 8, 2019
Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

PR-URL: #30023
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

PR-URL: #30023
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Nov 11, 2019
Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

PR-URL: #30023
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants