Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: join parts of disrupt section in cli.md #30038

Closed
wants to merge 1 commit into from
Closed

doc: join parts of disrupt section in cli.md #30038

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Oct 19, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Also eliminate some redundancy.

It seems this is the history of this small confusion and redundancy:

4b74dae#diff-85b6573bc4afd5e06ed3b9d9b553635d

4fbefc4#diff-85b6573bc4afd5e06ed3b9d9b553635d

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Oct 19, 2019
@Trott
Copy link
Member

Trott commented Oct 19, 2019

Commit message nit: Maybe mention that it's for the CLI docs?

@vsemozhetbyt
doc: join parts of disrupt section in cli.md
1d8abad 
Also eliminate some redundancy.
@vsemozhetbyt vsemozhetbyt changed the title doc: join parts of disrupt section doc: join parts of disrupt section in cli.md Oct 19, 2019
@vsemozhetbyt
Copy link
Contributor Author

Done)

@Trott
Copy link
Member

Trott commented Oct 19, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4003/

Trott pushed a commit that referenced this pull request Oct 22, 2019
@vsemozhetbyt @Trott
doc: join parts of disrupt section in cli.md
0ecd3c6 
Also eliminate some redundancy.

PR-URL: #30038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 22, 2019

Landed in 0ecd3c6

@Trott Trott closed this Oct 22, 2019
@vsemozhetbyt vsemozhetbyt deleted the doc-cli-join-section branch October 22, 2019 18:42
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
@vsemozhetbyt @MylesBorins
doc: join parts of disrupt section in cli.md
53d1955 
Also eliminate some redundancy.

PR-URL: #30038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
@vsemozhetbyt @MylesBorins
doc: join parts of disrupt section in cli.md
35bffcd 
Also eliminate some redundancy.

PR-URL: #30038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 23, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@vsemozhetbyt @targos
doc: join parts of disrupt section in cli.md
3a45c7b 
Also eliminate some redundancy.

PR-URL: #30038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@vsemozhetbyt @targos
doc: join parts of disrupt section in cli.md
c3dbdc3 
Also eliminate some redundancy.

PR-URL: #30038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@vsemozhetbyt @targos
doc: join parts of disrupt section in cli.md
870c320 
Also eliminate some redundancy.

PR-URL: #30038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vsemozhetbyt @Trott @addaleax @lpinca @cjihrig @richardlau @gireeshpunathil @ZYSzys @nodejs-github-bot